Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defunct query.remote-task.min-error-duration configuration #17722

Conversation

findepi
Copy link
Member

@findepi findepi commented Jun 1, 2023

The configuration query.remote-task.min-error-duration is ignored since c4092b0 removed the QueryManagerConfig.remoteTaskMinErrorDuration field.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jun 1, 2023
@findepi findepi requested review from dain, losipiuk and sopel39 June 1, 2023 08:13
@cla-bot cla-bot bot added the cla-signed label Jun 1, 2023
findepi added 2 commits June 1, 2023 10:16
The configuration `query.remote-task.min-error-duration` is ignored
since c4092b0 removed the
`QueryManagerConfig.remoteTaskMinErrorDuration` field.
The configuration `exchange.min-error-duration` is ignored
since c4092b0 removed the
`QueryManagerConfig.remoteTaskMinErrorDuration` field.
@findepi findepi force-pushed the findepi/remove-defunct-query-remote-task-min-error-duration-configuration-8cfb87 branch from af28cb4 to 8c164da Compare June 1, 2023 08:18
@findepi
Copy link
Member Author

findepi commented Jun 2, 2023

CI #16277

@findepi findepi merged commit e9181f3 into trinodb:master Jun 2, 2023
@findepi findepi deleted the findepi/remove-defunct-query-remote-task-min-error-duration-configuration-8cfb87 branch June 2, 2023 11:16
@github-actions github-actions bot added this to the 419 milestone Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants