Use jvmkill Docker image when building Trino image #17529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
approved these changes
May 17, 2023
| apt-get install -y -q git gcc make && \ | ||
| git clone https://github.com/airlift/jvmkill /tmp/jvmkill && \ | ||
| make -C /tmp/jvmkill | ||
| FROM ghcr.io/airlift/jvmkill:latest AS jvmkill |
There was a problem hiding this comment.
Did you avoid a specific tag intentionally?
There was a problem hiding this comment.
Yeah, I only published a latest tag since jvmkill is simple and is essentially unchanged since it was first created.
|
lgtm, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This speeds up the build significantly and makes the CI more reliable.
Fixes #17512
Release notes
(x) This is not user-visible or docs only and no release notes are required.