Support reading timestamp_ntz type (timestampNtz) in Delta Lake
#17502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz
branch
3 times, most recently
from
1e61d0e to
bfebcaf
Compare
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz
branch
from
bfebcaf to
71bfbe0
Compare
ebyhr
commented
May 16, 2023
...elta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeSchemaSupport.java
Show resolved
Hide resolved
ebyhr
commented
May 19, 2023
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Show resolved
Hide resolved
findinpath
reviewed
Jun 4, 2023
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz
branch
from
71bfbe0 to
5116813
Compare
|
Rebased on master to resolve conflicts. |
pajaks
approved these changes
Jun 6, 2023
findinpath
approved these changes
Jun 7, 2023
|
@ebyhr in PR title should it be |
ebyhr
changed the title
timestamp_ntz type in Delta Laketimestamp_ntz type (timestampNtz) in Delta Lake
|
Updated the PR title to mention both. |
|
@ebyhr i see that the type has been added in Delta OSS 2.4.0 https://github.com/delta-io/delta/releases/tag/v2.4.0 Could you pls attempt a product tests with Delta OSS for this feature? |
This requires #17667, but we can't merge the PR due to broken Databricks environment. I will add product tests once it's resolved. |
findepi
reviewed
Jul 4, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaHiveTypeTranslator.java
Show resolved
Hide resolved
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogParser.java
Show resolved
Hide resolved
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogParser.java
Outdated
Show resolved
Hide resolved
...in/java/io/trino/plugin/deltalake/transactionlog/statistics/DeltaLakeJsonFileStatistics.java
Outdated
Show resolved
Hide resolved
...in/java/io/trino/plugin/deltalake/transactionlog/statistics/DeltaLakeJsonFileStatistics.java
Show resolved
Hide resolved
...in/java/io/trino/plugin/deltalake/transactionlog/statistics/DeltaLakeJsonFileStatistics.java
Outdated
Show resolved
Hide resolved
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogParser.java
Outdated
Show resolved
Hide resolved
|
Just rebased on master to resolve conflicts. |
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz
branch
from
5116813 to
9dbff61
Compare
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz
branch
2 times, most recently
from
61c289f to
4cab975
Compare
ebyhr
force-pushed
the
ebi/delta-timestamp-ntz
branch
from
4cab975 to
96751d9
Compare
findepi
approved these changes
Jul 21, 2023
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support reading
timestamp_ntztype in Delta Lake. Writing the type is out of scope because our max writer version (5) doesn't support writer features (7). The type was added in Databricks 13 and the latest OSS Delta Lake doesn't support it type. I generated the resource file on Databricks 13.1Relates to #16927
Release notes
(x) Release notes are required, with the following suggested text: