Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make style of anchors consistent across docs #17442

Merged
merged 1 commit into from
May 11, 2023

Conversation

michaeleby1
Copy link
Contributor

@michaeleby1 michaeleby1 commented May 10, 2023

Description

All anchors in Trino docs should be written with hyphens .. _name-of-ref:, however some older anchors use underscores .. _name_of_ref:
624 anchors use hyphens and 214 anchors use underscores
This PR changes those underscores to hyphens

The :ref: links must also be changed to point to the anchors
983 :ref: links use hyphens and 351 :ref: links use underschors
This PR changes those underscores to hyphens

I tested the build locally to ensure there were no issues

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 10, 2023
@michaeleby1 michaeleby1 requested review from mosabua and jhlodin May 10, 2023 14:43
@jhlodin jhlodin requested review from m57lyra and mosabua and removed request for mosabua May 10, 2023 21:07
@jhlodin
Copy link
Contributor

jhlodin commented May 10, 2023

Please squash the two commits @michaeleby1

@mosabua mosabua added the docs label May 11, 2023
Make style of ref links consistent across docs
@michaeleby1 michaeleby1 force-pushed the me/standardize-ref-anchors branch from 3e89e53 to 71f9cbe Compare May 11, 2023 15:01
@michaeleby1
Copy link
Contributor Author

Please squash the two commits @michaeleby1

Done

@mosabua
Copy link
Member

mosabua commented May 11, 2023

Verified build locally. All good to go

@mosabua mosabua merged commit 5353db5 into trinodb:master May 11, 2023
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@github-actions github-actions bot added this to the 418 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants