Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct illegal import from shaded code #17441

Merged
merged 1 commit into from
May 11, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented May 10, 2023

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@wendigo
Copy link
Contributor Author

wendigo commented May 10, 2023

Follow-up airlift/airbase#355

Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start using <RestrictImports> to enforce this?

@hashhar
Copy link
Member

hashhar commented May 11, 2023

CI hit #14239

@hashhar hashhar merged commit 83fb1ac into trinodb:master May 11, 2023
@hashhar hashhar added the no-release-notes This pull request does not require release notes entry label May 11, 2023
@wendigo wendigo deleted the serafin/illegal-import branch May 11, 2023 08:51
@github-actions github-actions bot added this to the 418 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

5 participants