Fix reporting of row group size by parquet writer #17425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of parquet-tools Before Row group 25: count: 2240892 26.32 B records start: 1479039171 total(compressed): 56.243 MB total(uncompressed):56.243 MB After Row group 25: count: 2244256 26.34 B records start: 1479178837 total(compressed): 56.370 MB total(uncompressed):167.418 MB
sopel39
approved these changes
May 10, 2023
lib/trino-parquet/src/main/java/io/trino/parquet/writer/ParquetWriter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Output of
parquet-tools metaBefore
Row group 25: count: 2240892 26.32 B records start: 1479039171 total(compressed): 56.243 MB total(uncompressed):56.243 MB
After
Row group 25: count: 2244256 26.34 B records start: 1479178837 total(compressed): 56.370 MB total(uncompressed):167.418 MB
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: