Enable Hive optimized Parquet writer by default

[electrum]

Release notes

(x) Release notes are required, with the following suggested text:

# Hive
* Enable the optimized Parquet writer by default. This can be disabled using
  the `parquet.optimized-writer.enabled` configuration property or
  the `parquet_optimized_writer_enabled` session property. ({issue}`17393`)

[raunaqmorarka]

We also need an update to hive.rst to update default value for parquet.optimized-writer.enabled

[electrum]

@raunaqmorarka Thanks for the fast review. I updated the PR.

[github-actions]

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4922568047

[sopel39]

@electrum should we increase Parquet validation? Right now it's 5% in Hive.

[electrum]

@sopel39 That's a sampling percentage per file, so it should trigger for most queries. We could increase if you think it's valuable.

[sopel39]

@electrum I will defer to @raunaqmorarka for validation % as he did most of writer improvements recently. I was thinking about something more conservative like 100% for few releases as potential implications of bad writers would be considerable.

[raunaqmorarka]

The performance and cost (S3 requests cost $) implications would be significant enough that if we set the validation percentage too high, users would notice the difference and likely turn off the optimized writer or set the validation to 0. That would defeat the purpose of validation. So the number should be low enough that most users are not significantly hindered by it.
I wouldn't set it higher than 10, current default of 5 is also reasonable. If a bug is going to be found by validation, we would have to be very unlucky to miss it completely at 5% validation too.

[mosabua]

I think we can leave "by default" out

[electrum]

I agree, though we have that for several other properties as well. I assume that's because the config is setting the default value for the session property, but I agree that documenting it like that is confusing. Let's follow up in a separate PR to remove that for all of them.

[findepi]

"Add constraints for Parquet writer block and pages sizes"

[findepi]

Same in DeltaLakeSessionProperties and IcebergSessionProperties

[findepi]

lgtm