Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestRedshiftConnectorTest and deny adding not columns explicitly #17381

Merged
merged 2 commits into from
May 11, 2023
Merged

Fix TestRedshiftConnectorTest and deny adding not columns explicitly #17381

merged 2 commits into from
May 11, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented May 8, 2023 •
edited
Loading

Supersedes #17361

@cla-bot cla-bot bot added the cla-signed label May 8, 2023
@ebyhr ebyhr mentioned this pull request May 8, 2023
Closed
@ebyhr ebyhr force-pushed the ebi/gn/fixTestRedshiftConnectorTestBehavior branch 2 times, most recently from efc3937 to 872ddb7 Compare May 10, 2023 22:48
@ebyhr ebyhr changed the title Test: Fix TestRedshiftConnectorTest TestingConnectorBehavior Fix TestRedshiftConnectorTest and deny adding not columns explicitly May 11, 2023
@ebyhr ebyhr marked this pull request as ready for review May 11, 2023 07:29
@ebyhr
Copy link
Member Author

ebyhr commented May 11, 2023 •
edited
Loading

I will drop the first "!drop..." commit before merging this PR.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label May 11, 2023
hashhar
hashhar approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % dropping 1st commit

ebyhr and others added 2 commits May 11, 2023 17:46
@ebyhr @grantatspothero
Fix TestRedshiftConnectorTest TestingConnectorBehavior
989e624 
Also, adjust the failure message in testDecimalAvgPushdownForMaximumDecimalScale.

Does not run in CI and became stale after: 6781fa3

Co-Authored-By: Grant Nicholas <[email protected]>
@ebyhr
Deny adding a not null column in Redshift connector
22c0b2c
@ebyhr ebyhr force-pushed the ebi/gn/fixTestRedshiftConnectorTestBehavior branch from 872ddb7 to 22c0b2c Compare May 11, 2023 08:47
@ebyhr ebyhr merged commit 24f0c70 into master May 11, 2023
@ebyhr ebyhr deleted the ebi/gn/fixTestRedshiftConnectorTestBehavior branch May 11, 2023 08:51
@github-actions github-actions bot added this to the 418 milestone May 11, 2023
@colebow colebow mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@findepi findepi Awaiting requested review from findepi

@grantatspothero grantatspothero Awaiting requested review from grantatspothero

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
418
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @hashhar