Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of DeltaLakeTableHandle.projectedColumns #17365

Merged
merged 2 commits into from
May 12, 2023
Merged

Fix type of DeltaLakeTableHandle.projectedColumns #17365

merged 2 commits into from
May 12, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented May 5, 2023

It's a collection of Delta column handles.

@findepi findepi requested review from raunaqmorarka and krvikash May 5, 2023 18:32
@cla-bot cla-bot bot added the cla-signed label May 5, 2023
@findepi findepi mentioned this pull request May 5, 2023
Merged
@github-actions github-actions bot added the delta-lake Delta Lake connector label May 5, 2023
@findinpath findinpath self-requested a review May 10, 2023 05:11
@findepi findepi force-pushed the findepi/fix-type-of-deltalaketablehandle-projectedcolumns-2074b4 branch from 7ace1f3 to a60ea14 Compare May 10, 2023 13:20
krvikash
krvikash approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@krvikash krvikash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might need to remove below line

trino/plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java

Line 571 in 60c0042

.map(DeltaLakeColumnHandle.class::cast) // TODO DeltaLakeTableHandle.projectedColumns should be a collection of DeltaLakeColumnHandle

@findepi
Fix type of DeltaLakeTableHandle.projectedColumns
e7f11d3 
It's a collection of Delta column handles.
@findepi findepi force-pushed the findepi/fix-type-of-deltalaketablehandle-projectedcolumns-2074b4 branch from a60ea14 to e7f11d3 Compare May 10, 2023 15:18
@findepi
Copy link
Member Author

findepi commented May 12, 2023

CI #15187

@findepi findepi merged commit 8faef44 into trinodb:master May 12, 2023
@findepi findepi deleted the findepi/fix-type-of-deltalaketablehandle-projectedcolumns-2074b4 branch May 12, 2023 11:18
@github-actions github-actions bot added this to the 418 milestone May 12, 2023
@colebow colebow mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath approved these changes

@krvikash krvikash krvikash approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector
Milestone
418
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @raunaqmorarka @krvikash @findinpath