Add flag if task is speculative to TaskStatus #17318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
changed the title
findepi
reviewed
May 2, 2023
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/spec-spec-flag-in-task-status
branch
3 times, most recently
from
9fb0725 to
1cf45a5
Compare
arhimondr
approved these changes
May 9, 2023
losipiuk
force-pushed
the
lo/spec-spec-flag-in-task-status
branch
2 times, most recently
from
dbf11d7 to
d87c82e
Compare
losipiuk
force-pushed
the
lo/spec-spec-flag-in-task-status
branch
from
d87c82e to
309df3e
Compare
linzebing
approved these changes
May 10, 2023
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
linzebing
approved these changes
May 10, 2023
Previously there was a brittle assumption that addOrUpdate is called with just once for non-speculative task and for speculative task we get exactly two calls - add with speculative priority and with - update with non-speculative priority This PR makes logic more explicit and relaxes assumptions
losipiuk
force-pushed
the
lo/spec-spec-flag-in-task-status
branch
from
309df3e to
2c302ba
Compare
|
CI: #17158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #17305
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: