Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Confluent repo in record decoder module #17243

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

nineinchnick
Copy link
Member

Description

#16836 added io.confluent:kafka-protobuf-provider:jar:7.3.1 as a dependency of the trino-record-decoder module, but didn't add the Confluent repository. The CI in the PR might have passed if it used a cached local Maven repository, but now is failing on master and other branches. Fixes #17230

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

<repositories>
<repository>
<id>confluent</id>
<url>https://packages.confluent.io/maven/</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this make us hit confluent maven repo (first, before maven central) for all artifacts needed by this module?

Copy link
Member

@adamjshook adamjshook Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the effective pom for this module. It is listed first so I think that means Maven will hit it first to find artifacts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and that's not desireable.

pre-existing (trino-pinot, trino-kafka), so no change requested

@hashhar
Copy link
Member

hashhar commented Apr 27, 2023

The CI in the PR might have passed if it used a cached local Maven repository

I don't understand this part. The cache is based on recursive pom.xml hash so how could a pom.xml change use a cache?

@nineinchnick
Copy link
Member Author

We restore cache from master if there's no hit on the exact key.

@hashhar
Copy link
Member

hashhar commented Apr 27, 2023

Ah, seems so indeed -

restore-keys: |
${{ runner.os }}-maven-

@findepi findepi merged commit a57df5f into trinodb:master Apr 27, 2023
@github-actions github-actions bot added this to the 415 milestone Apr 27, 2023
@nineinchnick nineinchnick deleted the confluent-repo branch May 27, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants