Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test JDBC flush_metadata_cache sequentially #17211

Conversation

findepi
Copy link
Member

@findepi findepi commented Apr 24, 2023

Extract JDBC's flush_metadata_cache procedure tests into separate class and run it sequentially. These tests interfered with each other when running in parallel.

Fixes #17210

Extract JDBC's `flush_metadata_cache` procedure tests into separate
class and run it sequentially.  These tests interfered with each other
when running in parallel.
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised it didn't happen too often.

@findepi
Copy link
Member Author

findepi commented Apr 24, 2023

I'm surprised it didn't happen too often.

i was surprised to see it happen more than once in #17174
Delta's procedure with same name caused entropy change?

@findepi findepi merged commit d7587fb into trinodb:master Apr 25, 2023
@findepi findepi deleted the findepi/test-jdbc-flush-metadata-cache-sequentially-5da20f branch April 25, 2023 07:21
@github-actions github-actions bot added this to the 415 milestone Apr 25, 2023
@colebow colebow added the no-release-notes This pull request does not require release notes entry label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

Flaky test TestJdbcCachingConnectorSmokeTest
5 participants