Add support for Oracle fault tolerant execution #17200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
reviewed
Apr 25, 2023
.github/workflows/ci.yml
Outdated
| @@ -571,6 +571,7 @@ jobs: | |||
| - { modules: plugin/trino-mysql } | |||
| - { modules: plugin/trino-mysql, profile: fte-tests } | |||
| - { modules: plugin/trino-oracle } | |||
| - { modules: plugin/trino-oracle, profile: fte-tests } | |||
There was a problem hiding this comment.
please rebase on master and see a9aa9d0 to combine fte-tests together as normal module tests if they don't take very long to run.
There was a problem hiding this comment.
So didn't it make sense to combine fte and non-fte tests?
There was a problem hiding this comment.
Can be combined. It's 18m for normal test + 8min for FTE.
losipiuk
reviewed
Apr 25, 2023
...e/src/test/java/io/trino/plugin/oracle/TestOracleTaskFailureRecoveryWithPoolEnabledTest.java
Outdated
Show resolved
Hide resolved
hashhar
reviewed
Apr 26, 2023
plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/BaseOracleFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/BaseOracleFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ashhar Hasan <[email protected]>
Co-authored-by: Ashhar Hasan <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Fixes #17199
Release notes
(x) Release notes are required, with the following suggested text: