Fail the build if a non-existent Maven profile is used #17198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Maven just logs a warning if a non-existent profile is specified with . Enforcer plugin has a rule to fail the build in such cases. This avoids cases where a typo or incorrect ci.yml makes the build appear green even though some expected profile wasn't used.
nineinchnick
approved these changes
Apr 24, 2023
|
Can this be a problem when i want to enable some profile (eg cloud-tests), and it exists only for some of the modules? i am OK with the change, but I am concerned this may cause some problems somewhere later and may need revisiting. |
findepi
approved these changes
Apr 24, 2023
wendigo
approved these changes
Apr 24, 2023
No, it verifies that the profile exists in the "build". i.e. as long as the profile is found in one of the modules the check is happy. Verified using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default Maven just logs a warning if a non-existent profile is specified with . Enforcer plugin has a rule to fail the build in such cases. This avoids cases where a typo or incorrect ci.yml makes the build appear green even though some expected profile wasn't used.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
I noticed this while working on #17167