Remove unused codepath in AvroColumnDecoder #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If decoding to a REAL then getLong is called.
elonazoulay
force-pushed
the
remove_unused
branch
from
d0d6ca7 to
93e6502
Compare
kokosing
approved these changes
Apr 24, 2023
|
Thanks |
jklamer
reviewed
Apr 24, 2023
| @@ -178,7 +178,7 @@ public boolean isNull() | |||
| @Override | |||
| public double getDouble() | |||
| { | |||
| if (value instanceof Double || value instanceof Float) { | |||
There was a problem hiding this comment.
This is for avro data promotion and is needed.
colebow
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If decoding to a REAL then getLong is called.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: