-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for adaptive partitioning and adaptive task sizing of FTE #17179
Conversation
@@ -227,27 +227,17 @@ properties only apply to a ``TASK`` retry policy. | |||
* - Property name | |||
- Description | |||
- Default value | |||
* - ``fault-tolerant-execution-target-task-input-size`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the behavior for users who still have this (and other removed properties) configured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server startup will fail. Let me add this property to DefunctConfigs
6d748e1
to
6be2866
Compare
* - ``fault-tolerant-execution-arbitrary-distribution-compute-task-target-size-growth-factor`` | ||
- Growth factor for adaptive sizing of non-writer tasks of arbitrary | ||
distribution for fault-tolerant execution. | ||
- ``1.2`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any upper or lower bounds? Also what does this mean .. explain "growth factor" ... I think it means you add 20% each time .. right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower bound is 1.0. Thanks for the reminder, I have added a commit to enforce this check.
think it means you add 20% each time .. right?
Yes. Let me add more color around this one.
6be2866
to
4238e1d
Compare
Failure is not related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments, then LGTM
4238e1d
to
51d0dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extremely tiny nit, but LGTM. May also require wrapping onto the next line.
* **Default value:** ``false`` | ||
* **Session property:** ``determine_partition_count_for_write_enabled`` | ||
|
||
Enables determining the number of partitions based on amount of data read and processed by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enables determining the number of partitions based on amount of data read and processed by the | |
Enables determining the number of partitions based on the amount of data read and processed by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. Thank you @linzebing .. we will follow up with further improvements as discussed in a separate PR.
Description
Add documentation for adaptive partitioning and adaptive task sizing of FTE
Additional context and related issues
Add docs for #16719 and #17024
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: