Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apparent correctness issue with calculatePrefixesWithTableName #17121

Conversation

findepi
Copy link
Member

@findepi findepi commented Apr 19, 2023

There was a tight coupling between the method implementation and its caller.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Apr 19, 2023
@findepi findepi requested review from huberty89 and kokosing April 19, 2023 10:18
@cla-bot cla-bot bot added the cla-signed label Apr 19, 2023
findepi added 3 commits April 20, 2023 21:13
There was a tight coupling between the method implementation and its
caller.
listTables already includes views (and materialized views).
@findepi findepi force-pushed the findepi/remove-apparent-correctness-issue-with-calculateprefixeswithtablename-40d211 branch from f915792 to 88762e6 Compare April 20, 2023 19:13
@findepi findepi merged commit 1474245 into trinodb:master Apr 21, 2023
@findepi findepi deleted the findepi/remove-apparent-correctness-issue-with-calculateprefixeswithtablename-40d211 branch April 21, 2023 12:09
@github-actions github-actions bot added this to the 415 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants