Remove function name from TableFunctionHandle #17117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiafi
force-pushed
the
485TFHandle
branch
3 times, most recently
from
f555c2e to
8407cd4
Compare
martint
approved these changes
Apr 20, 2023
core/trino-main/src/test/java/io/trino/connector/TestingTableFunctions.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/TestTableFunctionInvocation.java
Outdated
Show resolved
Hide resolved
Use the ConnectorTableFunctionHandle as the function's identity in ConnectorSplitManager and FunctionProvider.
colebow
added
no-release-notes
|
No, it’s an internal change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ConnectorTableFunctionHandle as the function's identity in ConnectorSplitManager and FunctionProvider.
Changes spi methods
FunctionProvider.getTableFunctionProcessorProviderandConnectorSplitManager.getSplits. The methods are marked as@Experimental.Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: