Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ignite schema change operation tests failure #17102

Merged
merged 1 commit into from
May 16, 2023
Merged

Fix Ignite schema change operation tests failure #17102

merged 1 commit into from
May 16, 2023

Conversation

chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Apr 18, 2023

Description

Fix #16671

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Apr 18, 2023
@ebyhr
Copy link
Member

ebyhr commented Apr 18, 2023

Could you change to draft PR and fix the title to clarify this PR isn't ready for review?

@chenjian2664 chenjian2664 marked this pull request as draft April 18, 2023 22:04
@chenjian2664 chenjian2664 changed the title Add tests Fix Ignite schema change operation tests Apr 19, 2023
@chenjian2664
Copy link
Contributor Author

#16882 could be solved as well

@chenjian2664 chenjian2664 self-assigned this Apr 21, 2023
@chenjian2664
Copy link
Contributor Author

@chenjian2664
Copy link
Contributor Author

@chenjian2664
Copy link
Contributor Author

I will send the pr to solve the #16882, as we can see the above tests, there is no #16882 occurs after we upgrade the version to 2.9. cc @ebyhr

@chenjian2664 chenjian2664 changed the title Fix Ignite schema change operation tests Fix Ignite schema change operation tests failure Apr 26, 2023
@chenjian2664 chenjian2664 marked this pull request as ready for review April 26, 2023 13:09
@chenjian2664 chenjian2664 marked this pull request as draft May 14, 2023 14:12
@chenjian2664 chenjian2664 marked this pull request as ready for review May 16, 2023 05:47
@findepi findepi requested review from hashhar and removed request for findepi May 16, 2023 06:58
@kokosing kokosing merged commit 416dada into trinodb:master May 16, 2023
@kokosing
Copy link
Member

Thank you!

@github-actions github-actions bot added this to the 418 milestone May 16, 2023
@chenjian2664 chenjian2664 deleted the ignite_test_fail branch May 16, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants