Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for comments on views for Delta Lake #17089

Merged
merged 3 commits into from
May 9, 2023
Merged

Support for comments on views for Delta Lake #17089

merged 3 commits into from
May 9, 2023

Conversation

marcinsbd
Copy link
Contributor

@marcinsbd marcinsbd commented Apr 18, 2023 •
edited by ebyhr
Loading

Description

Support for comments on views for Delta Lake

Release notes

(x) Release notes are required, with the following suggested text:

# Delta Lake
* Add support for [`COMMENT ON VIEW`](/sql/comment). ({issue}`17089`)

@cla-bot
Copy link

cla-bot bot commented Apr 18, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr
ebyhr reviewed Apr 18, 2023
View reviewed changes
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java Outdated Show resolved Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java Outdated Show resolved Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java Outdated Show resolved Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/TrinoViewHiveMetastore.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java Outdated Show resolved Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/TrinoViewHiveMetastore.java Outdated Show resolved Hide resolved
@github-actions github-actions bot added delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector tests:hive labels Apr 18, 2023
@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from f5cf678 to 62830ad Compare April 18, 2023 12:51
@cla-bot
Copy link

cla-bot bot commented Apr 18, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd requested a review from ebyhr April 18, 2023 12:56
@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 62830ad to afa4226 Compare April 18, 2023 13:07
@cla-bot
Copy link

cla-bot bot commented Apr 18, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Member

ebyhr commented Apr 18, 2023

/test-with-secrets sha=afa4226e9efea8e38d331e122a95344185fe0432

@github-actions
Copy link

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4737547093

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from afa4226 to 10475d8 Compare April 20, 2023 16:36
@cla-bot
Copy link

cla-bot bot commented Apr 20, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 10475d8 to f83f912 Compare April 21, 2023 09:54
@cla-bot
Copy link

cla-bot bot commented Apr 21, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd requested a review from homar April 24, 2023 12:06
@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from f83f912 to 24d40c4 Compare April 25, 2023 23:00
@cla-bot
Copy link

cla-bot bot commented Apr 25, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 946bcc4 to 1b9d229 Compare April 26, 2023 11:32
@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 8761c17 to 49f65c0 Compare April 26, 2023 11:41
@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 49f65c0 to bf7db2f Compare April 26, 2023 12:30
@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from bf7db2f to 4c88d98 Compare April 26, 2023 12:49
@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 4c88d98 to 348ab59 Compare April 26, 2023 12:56
@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 348ab59 to 3559e1e Compare April 26, 2023 12:59
@cla-bot
Copy link

cla-bot bot commented Apr 26, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Member

ebyhr commented Apr 27, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Apr 27, 2023
@cla-bot
Copy link

cla-bot bot commented Apr 27, 2023

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr
Copy link
Member

ebyhr commented Apr 27, 2023

/test-with-secrets sha=3559e1e2a8df3d04f6d3abe55204e71826338715

@github-actions
Copy link

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4815509555

@ebyhr
Copy link
Member

ebyhr commented Apr 27, 2023

Could you confirm CI failure?

Error:  io.trino.plugin.deltalake.TestDeltaLakeConnectorTest.testCommentView  Time elapsed: 0.783 s  <<< FAILURE!
java.lang.AssertionError: Expected query to fail: COMMENT ON VIEW test_comment_view_s914dfc9cq IS 'new comment' [QueryId: 20230427_101823_00791_ndcm9]

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from 3559e1e to d69a105 Compare May 5, 2023 17:05
@ebyhr
Copy link
Member

ebyhr commented May 7, 2023 •
edited
Loading

TestDeltaLakeConnectorTest.testCommentViewColumn is still failing. Please ping me once you fix the CI failure.

@marcinsbd marcinsbd force-pushed the supports_comments_on_views_for_delta branch from d69a105 to 769a927 Compare May 8, 2023 09:33
@marcinsbd marcinsbd requested a review from ebyhr May 8, 2023 15:29
@ebyhr
Copy link
Member

ebyhr commented May 8, 2023

/test-with-secrets sha=769a9273860a1e2802efa7af00d1bf72bee763d2

@ebyhr ebyhr merged commit c0134f1 into trinodb:master May 9, 2023
@ebyhr ebyhr mentioned this pull request May 9, 2023
Closed
@github-actions github-actions bot added this to the 417 milestone May 9, 2023
@colebow colebow mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@homar homar Awaiting requested review from homar

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector
Milestone
417
Development

Successfully merging this pull request may close these issues.
2 participants
@marcinsbd @ebyhr