-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove table handle retriesEnabled field #17074
Merged
findepi
merged 4 commits into
trinodb:master
from
findepi:findepi/remove-table-handle-retriesenabled-field-6c7409
Apr 18, 2023
Merged
Remove table handle retriesEnabled field #17074
findepi
merged 4 commits into
trinodb:master
from
findepi:findepi/remove-table-handle-retriesenabled-field-6c7409
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
This pull request does not require release notes entry
label
Apr 17, 2023
findepi
requested review from
losipiuk,
mwd410,
ebyhr,
alexjo2144 and
findinpath
April 17, 2023 19:12
alexjo2144
approved these changes
Apr 17, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/remove-table-handle-retriesenabled-field-6c7409
branch
from
April 17, 2023 19:50
cab7da8
to
337f88e
Compare
alexjo2144
approved these changes
Apr 17, 2023
findepi
force-pushed
the
findepi/remove-table-handle-retriesenabled-field-6c7409
branch
from
April 17, 2023 20:14
337f88e
to
a393075
Compare
github-actions
bot
added
delta-lake
Delta Lake connector
hive
Hive connector
iceberg
Iceberg connector
tests:hive
labels
Apr 17, 2023
Avoid confusion with `DeltaLakeTableHandle handle`.
The table handle describes reads and retries do not matter for reads.
findepi
force-pushed
the
findepi/remove-table-handle-retriesenabled-field-6c7409
branch
from
April 18, 2023 06:40
a393075
to
95312e1
Compare
rebased to resolve conflicts |
losipiuk
approved these changes
Apr 18, 2023
findepi
deleted the
findepi/remove-table-handle-retriesenabled-field-6c7409
branch
April 18, 2023 06:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
delta-lake
Delta Lake connector
hive
Hive connector
iceberg
Iceberg connector
no-release-notes
This pull request does not require release notes entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table handle describes reads and retries do not matter for reads.