Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove table handle retriesEnabled field #17074

Conversation

findepi
Copy link
Member

@findepi findepi commented Apr 17, 2023

The table handle describes reads and retries do not matter for reads.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Apr 17, 2023
@cla-bot cla-bot bot added the cla-signed label Apr 17, 2023
@findepi findepi force-pushed the findepi/remove-table-handle-retriesenabled-field-6c7409 branch from cab7da8 to 337f88e Compare April 17, 2023 19:50
@findepi findepi requested a review from alexjo2144 April 17, 2023 19:50
@findepi findepi force-pushed the findepi/remove-table-handle-retriesenabled-field-6c7409 branch from 337f88e to a393075 Compare April 17, 2023 20:14
@github-actions github-actions bot added delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector tests:hive labels Apr 17, 2023
@findepi
Copy link
Member Author

findepi commented Apr 18, 2023

CI #16933, #16671

findepi added 4 commits April 18, 2023 08:37
"Split" is irregular.
Avoid confusion with `DeltaLakeTableHandle handle`.
The table handle describes reads and retries do not matter for reads.
@findepi findepi force-pushed the findepi/remove-table-handle-retriesenabled-field-6c7409 branch from a393075 to 95312e1 Compare April 18, 2023 06:40
@findepi
Copy link
Member Author

findepi commented Apr 18, 2023

rebased to resolve conflicts

@findepi findepi merged commit 0e69a72 into trinodb:master Apr 18, 2023
@findepi findepi deleted the findepi/remove-table-handle-retriesenabled-field-6c7409 branch April 18, 2023 06:50
@github-actions github-actions bot added this to the 414 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants