Add support for absolute path in Delta Lake connector

[vinay-kl]

Description

Support reading absolute paths from the Delta transaction log

Additional context and related issues

Fixes #17011

Release notes

(x) Release notes are required, with the following suggested text:

# Delta Lake
* Add support reading [shallow cloned tables](https://docs.databricks.com/sql/language-manual/delta-clone.html). ({issue}`17011`)

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 300070018.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[findinpath]

@vinay-kl pls follow the guideline https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages for commit messages.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 300070018.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[vinay-kl]

@ebyhr @alexjo2144 can you please review this PR

[findinpath]

Small checkstyle issues in your PR

Error:  src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java:[48,1] (imports) ImportOrder: Wrong order for 'java.util.Objects' import.
Error:  src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java:[311,88] (blocks) LeftCurly: '{' at column 88 should be on a new line.
Error:  src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java:[331,9] (blocks) RightCurly: '}' at column 9 should be alone on a line.
Error:  Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.1:check (checkstyle) on project trino-delta-lake: You have 3 Checkstyle violations. -> [Help 1]
Error:  

Address them and do a build before pushing:

mvn install -P errorprone-compiler -DskipTests -nsu -pl :trino-delta-lake

At this stage do consider a rebase.

git rebase -i $(git merge-base HEAD master)

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 300070018.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[alexjo2144]

Thanks for proposing a fix! There are a couple other places that use AddFileEntry.getPath() that probably also need an update but I don't think any others are used on the read path so we can look at them separately.

@findepi @findinpath we probably need to think through if all table operations make sense on clones. DML, Analyze, optimize, vacuum, etc.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 300070018.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 300070018.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[alexjo2144]

Changes are looking pretty good to me, just one more small clean up thing. Can you squash your changes and also include "Delta Lake" in the commit message?

@ebyhr @findepi I think this is ready for a maintainer to take a look

[alexjo2144]

@vinay-kl the CLA bot doesn't seem happy, have you filled one out?

[vinay-kl]

@vinay-kl the CLA bot doesn't seem happy, have you filled one out?

@alexjo2144 I have, The CLA was accepted and confirmation mail from martin was received yesterday, I'm not sure why the CLA issue still prevails.

[alexjo2144]

The CLA was accepted and confirmation mail from martin was received yesterday

Awesome. In that case, can you double check the couple steps listed in the bot's messages to make sure that your commits are tagged appropriately?

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 300070018.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[vinay-kl]

sorry, by mistakingly i closed this PR and don't suppose how to open this.. will raise another PR. Extremely sorry for inconvenience @alexjo2144 @findinpath

[krvikash]

Hi @vinay-kl, Reopened the PR.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 300070018.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[vinay-kl]

@krvikash Thank you so much for re-opening the PR.

[ebyhr]

Your account isn't yet registered in https://github.com/trinodb/cla. Please wait for a while.
cc: @martint

[vinay-kl]

@mosabua I will continue working on this PR, will submit the latest commit changes soon.

[findinpath]

@vinay-kl pls rebase on master to address the conflicts.

[findinpath]

can you please add a simple test showcasing the following scenario:

• create table t1
• spark: create table t2 shallow clone t1
• ensure that t2 and t1 have the same content
• trino: drop table t2
• ensure that the t1 table has the content intact
• trino: drop table t1

[findinpath]

LGTM % open nits

[ebyhr]

/test-with-secrets sha=ff0f20084d0e10b159893dd577b3d094e4792864

[github-actions]

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8507516113

[ebyhr]

as of v422

It's different from the current version. I would recommend removing.