Simplify TableFunctionSplitProcessor interface #17032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
approved these changes
Apr 14, 2023
findepi
force-pushed
the
findepi/refac-leaf-tf
branch
2 times, most recently
from
21e38d8 to
cbb1418
Compare
findepi
commented
Apr 14, 2023
| @@ -32,7 +33,7 @@ default TableFunctionDataProcessor getDataProcessor(ConnectorTableFunctionHandle | |||
| * This method returns a {@code TableFunctionSplitProcessor}. All the necessary information collected during analysis is available | |||
| * in the form of {@link ConnectorTableFunctionHandle}. It is called once per each split processed by the table function. | |||
| */ | |||
| default TableFunctionSplitProcessor getSplitProcessor(ConnectorSession session, ConnectorTableFunctionHandle handle) | |||
| default TableFunctionSplitProcessor getSplitProcessor(ConnectorSession session, ConnectorTableFunctionHandle handle, ConnectorSplit split) | |||
findepi
commented
Apr 14, 2023
| * @return {@link TableFunctionProcessorState} including the processor's state and optionally a portion of result. | ||
| * After the returned state is {@code FINISHED}, the method will not be called again for the split currently being processed | ||
| * and may be called with a new split. |
There was a problem hiding this comment.
This was actually incorrect, broken in #16955
findepi
requested review from
losipiuk,
alexjo2144 and
kasiafi
and removed request for
losipiuk,
kasiafi and
alexjo2144
kasiafi
approved these changes
Apr 18, 2023
core/trino-spi/src/main/java/io/trino/spi/ptf/TableFunctionSplitProcessor.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/LeafTableFunctionOperator.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/LeafTableFunctionOperator.java
Outdated
Show resolved
Hide resolved
|
The function |
findepi
force-pushed
the
findepi/refac-leaf-tf
branch
from
cbb1418 to
3fe52ff
Compare
|
(just rebased) |
findepi
force-pushed
the
findepi/refac-leaf-tf
branch
from
3fe52ff to
a8ae043
Compare
|
(just rebased, for real this time, undoing some other stuff pushed together with rebase) |
findepi
force-pushed
the
findepi/refac-leaf-tf
branch
from
a8ae043 to
cb0d0e6
Compare
|
AC |
kasiafi
reviewed
Apr 19, 2023
findepi
force-pushed
the
findepi/refac-leaf-tf
branch
from
cb0d0e6 to
305adfa
Compare
March 31 is in the past.
All table functions processing interfaces are experimental (for example `TableFunctionProcessorProvider`).
`ArrayList` should not be used for cases where we remove elements from the list start.
The `TableFunctionSplitProcessor` is used for one split only and then new instance of `TableFunctionSplitProcessor` is created. Provide the split directly to `TableFunctionProcessorProvider.getSplitProcessor` and do not provide it to `TableFunctionProcessor.process`. This removes conditionality of argument presence in the `process` method and so makes things simpler.
findepi
force-pushed
the
findepi/refac-leaf-tf
branch
from
305adfa to
f2ab11c
Compare
colebow
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TableFunctionSplitProcessoris used for one split only and thennew instance of
TableFunctionSplitProcessoris created.Provide the split directly to
TableFunctionProcessorProvider.getSplitProcessorand do not provide itto
TableFunctionProcessor.process. This removes conditionality ofargument presence in the
processmethod and so makes things simpler.