Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pushJoinIntoTableScan apply on merge target #17004

Closed
wants to merge 3 commits into from
Closed

Allow pushJoinIntoTableScan apply on merge target #17004

wants to merge 3 commits into from

Conversation

chenjian2664
Copy link
Contributor

Description

Fix #17003

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Apr 13, 2023
@Praveen2112
Copy link
Member

Can we add some test overages to it ?

@chenjian2664
Copy link
Contributor Author

Thanks @Praveen2112, I am adding 👍

@chenjian2664
Copy link
Contributor Author

@Praveen2112 Could you suggest where and how could to test for this part?
There is a test class TestPushJoinIntoTableScan but feel like not suitable to add test here, actually we need test is sth like "Test merge plan's right join, left scan table is a target". Any thoughts?

@chenjian2664 chenjian2664 self-assigned this Apr 24, 2023
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 16, 2024
@mosabua
Copy link
Member

mosabua commented Jan 16, 2024

👋 @chenjian2664 @Praveen2112 - this PR has become inactive. If you're still interested in working on it, please let us know.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.

@github-actions github-actions bot removed the stale label Jan 18, 2024
Copy link

github-actions bot commented Feb 9, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 9, 2024
Copy link

github-actions bot commented Mar 1, 2024

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Planning error when apply the rule 'PushJoinIntoTableScan'
3 participants