Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename class implementing Hive's flush_metadata_cache #16995

Conversation

findepi
Copy link
Member

@findepi findepi commented Apr 12, 2023

Name it consistently with the procedure name.

Copy link
Member

@aczajkowski aczajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % AFAR we names it with Hive as there are multiple FlushCacheProcedures in Trino. So this was allowing to easily distinguish them. But agree. Package is good enough and name sounds better now.

@github-actions github-actions bot added hive Hive connector tests:hive labels Apr 12, 2023
@findepi
Copy link
Member Author

findepi commented Apr 12, 2023

LGTM % AFAR we names it with Hive as there are multiple FlushCacheProcedures in Trino.

for distinguishing we would use "Hive" prefix, not infix.

btw i named it after Delta's io.trino.plugin.deltalake.procedure.FlushMetadataCacheProcedure

@findepi
Copy link
Member Author

findepi commented Apr 13, 2023

CI #17020

@findepi findepi merged commit 26d363b into trinodb:master Apr 13, 2023
@findepi findepi deleted the findepi/rename-class-implementing-hive-s-flush-metadata-cache-baaa74 branch April 13, 2023 12:05
@github-actions github-actions bot added this to the 414 milestone Apr 13, 2023
@colebow colebow added the no-release-notes This pull request does not require release notes entry label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

5 participants