Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Coral #16994

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Update Coral #16994

merged 1 commit into from
Apr 20, 2023

Conversation

ksobolew
Copy link
Contributor

Description

The previous version of Coral was about 11 months old by now. And Ivy 2.4.0 it depends on is also outdated.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 12, 2023
martint
martint reviewed Apr 12, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@ksobolew ksobolew force-pushed the kudi/bump-ivy branch 2 times, most recently from 875ff99 to c66475e Compare April 14, 2023 07:50
@ksobolew ksobolew mentioned this pull request Apr 14, 2023
Closed
@ksobolew ksobolew marked this pull request as ready for review April 14, 2023 11:10
@ksobolew ksobolew marked this pull request as draft April 14, 2023 11:26
@ksobolew ksobolew force-pushed the kudi/bump-ivy branch 2 times, most recently from c5b9b95 to 8241122 Compare April 14, 2023 14:23
@ksobolew ksobolew marked this pull request as ready for review April 17, 2023 11:13
@ksobolew
Copy link
Contributor Author

Also created a PR upstream: linkedin/coral#390

@ksobolew
Bump Coral version
d097f93 
The previous version was about 11 months old by now. Includes a bump of
Apache Ivy transitive dependency.
@ksobolew ksobolew changed the title Update Coral and Ivy Update Coral Apr 19, 2023
@ksobolew
Copy link
Contributor Author

Timeout in Cassandra product tests:

tests               | 2023-04-20 03:18:48 INFO: FAILURE     /    io.trino.tests.product.cassandra.TestSelect.testSelectAllTypePartitioningMaterializedView (Groups: profile_specific_tests, cassandra) took 13.4 seconds
tests               | 2023-04-20 03:18:48 SEVERE: Failure cause:
tests               | com.datastax.oss.driver.api.core.DriverTimeoutException: Query timed out after PT2S

@kokosing kokosing merged commit 0c99af4 into trinodb:master Apr 20, 2023
@ksobolew ksobolew deleted the kudi/bump-ivy branch April 20, 2023 14:53
@github-actions github-actions bot added this to the 415 milestone Apr 20, 2023
@colebow colebow mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint left review comments

@kokosing kokosing kokosing approved these changes

@wendigo wendigo Awaiting requested review from wendigo

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed
Milestone
415
Development

Successfully merging this pull request may close these issues.
3 participants
@ksobolew @martint @kokosing