Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document compression configuration for server log #16917

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

willshen
Copy link
Contributor

@willshen willshen commented Apr 6, 2023

Description

Document compression configuration for server log

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 6, 2023
@willshen willshen requested a review from mosabua April 6, 2023 14:55
@github-actions github-actions bot added the docs label Apr 6, 2023
@@ -56,6 +56,15 @@ rotation replaces old content.

The maximum file size for the general application log file.

``log.compression``
^^^^^^^^^^^^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to match the length of the text above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this - this is fixed now.

@mosabua
Copy link
Member

mosabua commented Apr 6, 2023

Refer to the readme file in the docs folder to see how you can build the docs locally to verify.

https://github.com/trinodb/trino/tree/master/docs

@willshen
Copy link
Contributor Author

willshen commented Apr 7, 2023

@mosabua Thank you for the pointer - I ran the build to make sure it built successfully after the fix now.

@electrum electrum merged commit 6b9893c into trinodb:master Apr 10, 2023
@willshen willshen deleted the patch-2 branch April 10, 2023 18:47
@github-actions github-actions bot added this to the 413 milestone Apr 10, 2023
@mosabua
Copy link
Member

mosabua commented Apr 11, 2023

Thank you for your contribution @willshen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants