-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Protobuf version #16890
Bump Protobuf version #16890
Conversation
The `protobuf-java` one was overriding a corresponding declaration in the parent POM, and was effectively downgrading it. The other two were not used at all.
I guess the |
0af376c
to
06fe5b8
Compare
@@ -34,26 +34,6 @@ | |||
</repository> | |||
</repositories> | |||
|
|||
<dependencyManagement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section was added in https://github.com/trinodb/trino/pull/7627/files to avoid conflicting versions.
As long as enforcer doesn't complain about required upper bounds then it's good to remove.
I'd like @elonazoulay to confirm this once though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, it doesn't complain (on older releases it complains about zookeeper only; seems most of this section is long obsolete)
@kokosing please merge |
failed with "Unsupported platform: protoc-3.22.2-osx-aarch_64.exe" not sure if related |
Was it locally? M1 Mac? (I don't have one so I can't verify, but if protobuf doesn't have support for M1, then I don't know if I can do anything here.) |
Description
Impersonating a dependabot here.
Additional context and related issues
Also removes unnecessary
dependencyManagement
intrino-pinot
. Unless it's very important to keep it at a lower version?Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: