Add support for rounding negative decimal places #1689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Oct 7, 2019
presto-main/src/main/java/io/prestosql/operator/scalar/MathFunctions.java
Outdated
Show resolved
Hide resolved
|
@jlabarbera11 Thanks for addressing this issue! |
jlabarbera11
force-pushed
the
round_long
branch
from
bf38ea4 to
2f251a5
Compare
jlabarbera11
changed the title
findepi
reviewed
Oct 9, 2019
presto-main/src/test/java/io/prestosql/operator/scalar/TestMathFunctions.java
Show resolved
Hide resolved
presto-main/src/test/java/io/prestosql/operator/scalar/TestMathFunctions.java
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/operator/scalar/MathFunctions.java
Outdated
Show resolved
Hide resolved
|
|
||
| double factor = Math.pow(10, -decimals); | ||
| if (factor > Long.MAX_VALUE) { | ||
| throw new PrestoException(NUMERIC_VALUE_OUT_OF_RANGE, "decimal overflow: " + decimals); |
There was a problem hiding this comment.
this will need improvement, but i need to think about this yet
presto-main/src/test/java/io/prestosql/operator/scalar/TestMathFunctions.java
Show resolved
Hide resolved
jlabarbera11
force-pushed
the
round_long
branch
from
2f251a5 to
537d009
Compare
jlabarbera11
force-pushed
the
round_long
branch
from
537d009 to
5e60ce9
Compare
|
Merged as b91aeaf, thanks! (i added 5 more test cases) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #42