Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend maven-checks job timeout by additional 5 minutes #16863

Conversation

MiguelWeezardo
Copy link
Member

@MiguelWeezardo MiguelWeezardo commented Apr 3, 2023

Description

The recent merge of #16098 increased build robustness in the event of main Ubuntu repo failures at the cost of 2-3 minutes for downloading Ubuntu mirror indexes.

Additional context and related issues

It turns out the 45 minute timeout was very close to the actual time needed to perform the entire job, and extending it is necessary to avoid cancelling the job.
Recent failures were:

https://github.com/trinodb/trino/actions/runs/4584653136/jobs/8096275081?pr=16842
https://github.com/trinodb/trino/actions/runs/4593206872/jobs/8110920919?pr=16721

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

The recent merge of trinodb#16098
increased build robustness in the event of main Ubuntu repo failures,
at the cost of 2-3 minutes for downloading Ubuntu mirror indexes.

It turns out the 45 minute timeout was very close to the actual time
needed to perform the entire job, and extending it is
necessary to avoid cancelling the job.
@cla-bot cla-bot bot added the cla-signed label Apr 3, 2023
@MiguelWeezardo MiguelWeezardo requested review from hashhar and ebyhr April 3, 2023 21:31
@MiguelWeezardo
Copy link
Member Author

Hopefully this will solve the recent re-emergence of #11131

@electrum
Copy link
Member

electrum commented Apr 4, 2023

Thanks for investigating the failure. The Maven checks will continue take longer as we add more code to modules in the critical path, so we'll eventually hit this new limit.

I'm thinking we should split out the RPM and Docker checks into a different job, since they're unrelated to the Maven checks. This will allow us to get feedback quicker for both. We had them together since the Maven checks job already built the server, so testing Docker was convenient, but it's fine to do a fast build before testing Docker.

We can have the Maven checks job skip trino-server-rpm and trino-server. The new job can build the server, test the RPM, then test Docker.

What do you think?

@nineinchnick
Copy link
Member

I agree, we should split up the job. I think we care about fast feedback from Maven checks, but building and testing the Docker image could leverage the output of other jobs to avoid building everything again. The CI already takes too long, and we need to be careful about adding more overhead. But as usual, we need to measure build time vs artifacts download time.

But we also should merge this, since it'll take a while to split them up.

@MiguelWeezardo MiguelWeezardo added no-release-notes This pull request does not require release notes entry dx Issues or pull requests related to developer experience labels Apr 4, 2023
@MiguelWeezardo
Copy link
Member Author

Here's a draft PR for the maven-check job split @electrum mentioned: #16871

@ebyhr ebyhr removed their request for review April 25, 2023 10:05
@ebyhr
Copy link
Member

ebyhr commented Jun 15, 2023

Let me close as 40b5516 fixed the timeout issue. Thanks for working on this!

@ebyhr ebyhr closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed dx Issues or pull requests related to developer experience no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

4 participants