Upgrade Phoenix to 5.1.3 #16778
Merged
Upgrade Phoenix to 5.1.3 #16778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/upgrade-phoenix5
branch
from
9228658 to
d9a67a0
Compare
wendigo
force-pushed
the
serafin/upgrade-phoenix5
branch
from
d9a67a0 to
e98eb1c
Compare
|
This is ready to review. Phoenix 5.1.3 fixes NULL binary handling, which I've also fixed in our tests. |
hashhar
reviewed
Apr 11, 2023
plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixConnectorTest.java
Show resolved
Hide resolved
hashhar
force-pushed
the
serafin/upgrade-phoenix5
branch
from
7a0e5ab to
dd70c21
Compare
|
I just added a TODO to remind when it's time to remove the dependency. Will merge once CI finishes. |
|
Thx @hashhar |
hashhar
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: