Add quantile_at_value function #16736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrzypo987
requested review from
Praveen2112,
kokosing,
huberty89 and
atanasenko
Praveen2112
reviewed
Mar 27, 2023
core/trino-main/src/test/java/io/trino/operator/aggregation/TestQuantileDigestFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/QuantileDigestFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/aggregation/TestQuantileDigestFunctions.java
Outdated
Show resolved
Hide resolved
| QuantileDigest qdigest = new QuantileDigest(1); | ||
| addAll(qdigest, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9); | ||
| assertThat(assertions | ||
| .expression(format("quantile_at_value(CAST(a AS qdigest(bigint)), 20)")) |
There was a problem hiding this comment.
Is it possible to have a round-trip assertion here - based on the result from quantile_at_value - we could use it to apply value_at_quantile function and check if they are same.
There was a problem hiding this comment.
Excelent idea. Added as another commit.
skrzypo987
force-pushed
the
skrzypo/270-quantile-at-value
branch
from
77a92ad to
27d75c0
Compare
kokosing
approved these changes
Mar 27, 2023
skrzypo987
force-pushed
the
skrzypo/270-quantile-at-value
branch
from
27d75c0 to
a5be8b9
Compare
Co-authored-by: Peizhen Guo <[email protected]>
skrzypo987
force-pushed
the
skrzypo/270-quantile-at-value
branch
from
a5be8b9 to
d0d6da4
Compare
Praveen2112
approved these changes
Mar 28, 2023
|
Commits squashed. |
|
I think Clickhouse PTs are flaky - have created an issue for that - #16772. Post re-running it was green. |
|
Thank you for adding the new functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: