Reduce synchronization on PipelinedStageExecution #16717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
changed the title
pettyjamesm
force-pushed
the
reduce-pipelined-query-scheduler-synchronization
branch
from
c4edb36 to
d4bc175
Compare
pettyjamesm
deleted the
reduce-pipelined-query-scheduler-synchronization
branch
pettyjamesm
restored the
reduce-pipelined-query-scheduler-synchronization
branch
Removes synchronization from beginScheduling() and transitionToSchedulingSplits() both of which only perform state machine updates (if necessary) and do not require accessing synchronized state.
pettyjamesm
force-pushed
the
reduce-pipelined-query-scheduler-synchronization
branch
from
d4bc175 to
b0476b7
Compare
Dith3r
approved these changes
Mar 25, 2023
raunaqmorarka
approved these changes
Mar 25, 2023
pettyjamesm
deleted the
reduce-pipelined-query-scheduler-synchronization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes synchronization from
beginScheduling()andtransitionToSchedulingSplits()both of which only perform state machine updates (if necessary) and do not require accessing synchronized state.Follows up from #16585
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: