Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set thread name for DDL queries #16686

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Set thread name for DDL queries #16686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6e25f1
Set thread name for DDL queries
findepi Mar 23, 2023
676e9c7
Fix thread names in TestEventDrivenTaskSource
findepi Mar 23, 2023
e6e99eb
Remove unused constant in environment definition
findepi Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/trino-main/src/main/java/io/trino/execution/SqlQueryManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.google.common.collect.Ordering;
import com.google.common.util.concurrent.ListenableFuture;
import io.airlift.concurrent.SetThreadName;
import io.airlift.concurrent.ThreadPoolExecutorMBean;
import io.airlift.log.Logger;
import io.airlift.units.DataSize;
Expand Down Expand Up @@ -246,7 +247,9 @@ public void createQuery(QueryExecution queryExecution)
queryTracker.expireQuery(queryExecution.getQueryId());
});

queryExecution.start();
try (SetThreadName ignored = new SetThreadName("Query-%s", queryExecution.getQueryId())) {
queryExecution.start();
}
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion core/trino-main/src/test/java/io/trino/execution/scheduler/TestEventDrivenTaskSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public class TestEventDrivenTaskSource
@BeforeClass
public void setUp()
{
executor = listeningDecorator(newScheduledThreadPool(10, daemonThreadsNamed("dispatcher-query-%s")));
executor = listeningDecorator(newScheduledThreadPool(10, daemonThreadsNamed(getClass().getName())));
}

@AfterClass(alwaysRun = true)
Expand Down
3 changes: 0 additions & 3 deletions ...-launcher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import static io.trino.tests.product.launcher.env.common.Hadoop.CONTAINER_TRINO_HIVE_TIMESTAMP_NANOS;
import static io.trino.tests.product.launcher.env.common.Hadoop.CONTAINER_TRINO_HIVE_WITH_EXTERNAL_WRITES_PROPERTIES;
import static io.trino.tests.product.launcher.env.common.Hadoop.CONTAINER_TRINO_ICEBERG_PROPERTIES;
import static io.trino.tests.product.launcher.env.common.Standard.CONTAINER_TRINO_ETC;
import static io.trino.tests.product.launcher.env.common.Standard.CONTAINER_TRINO_JVM_CONFIG;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.utility.MountableFile.forHostPath;
Expand All @@ -39,8 +38,6 @@
public final class EnvMultinode
extends EnvironmentProvider
{
public static final String CONTAINER_TRINO_HIVE_ACCESS_CONTROL = CONTAINER_TRINO_ETC + "/catalog/hive.properties";

private final DockerFiles dockerFiles;
private final DockerFiles.ResourceProvider configDir;

Expand Down