Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip listing Glue tables with invalid column types #16677

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Skip listing Glue tables with invalid column types #16677

merged 2 commits into from
Mar 23, 2023

Conversation

electrum
Copy link
Member

@electrum electrum commented Mar 22, 2023 •
edited
Loading

Release notes

(x) Release notes are required, with the following suggested text:

# Hive
* Skip listing Glue tables with invalid column types. ({issue}`16677`)

@cla-bot cla-bot bot added the cla-signed label Mar 22, 2023
@electrum electrum changed the title Glue badtype Skip listing Glue tables with invalid column types Mar 22, 2023
@github-actions github-actions bot added hive Hive connector tests:hive labels Mar 22, 2023
hashhar
hashhar approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think it's not possible to add a test since neither Trino nor Hive creates such problematic columns.

@electrum electrum merged commit 6be53c1 into trinodb:master Mar 23, 2023
@electrum electrum deleted the glue-badtype branch March 23, 2023 11:59
@github-actions github-actions bot added this to the 411 milestone Mar 23, 2023
@colebow colebow mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed hive Hive connector
Milestone
411
Development

Successfully merging this pull request may close these issues.
2 participants
@electrum @hashhar