Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kill-switch to disable automatic fetch-size selection #16670

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 22, 2023

The configuration toggles xxx.disable-automatic-fetch-size were
introduced only temporarily, as a kill-switch.

To be merged after some time since #16644 is merged and released (in 411).

@cla-bot cla-bot bot added the cla-signed label Mar 22, 2023
@github-actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added stale and removed stale labels Apr 28, 2023
@findepi findepi force-pushed the findepi/remove-disable-automatic-fetch-size-kill-switch branch from 0b38b39 to e091d15 Compare May 4, 2023 14:18
@findepi findepi requested review from wendigo, ebyhr, kokosing and hashhar May 4, 2023 14:19
@findepi findepi added the no-release-notes This pull request does not require release notes entry label May 5, 2023
The configuration toggles `xxx.disable-automatic-fetch-size` were
introduced only temporarily, as a kill-switch.
@findepi findepi force-pushed the findepi/remove-disable-automatic-fetch-size-kill-switch branch from e091d15 to 91b4bf0 Compare May 5, 2023 10:46
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice .. lets ship this now. I confirm that this was never documented so there is no need to remove anything from the docs ;-)

@findepi findepi merged commit 58d44a2 into trinodb:master May 5, 2023
@findepi findepi deleted the findepi/remove-disable-automatic-fetch-size-kill-switch branch May 5, 2023 18:18
@github-actions github-actions bot added this to the 417 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants