Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of TDigestHistogram allocations #16669

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Mar 22, 2023

On coordinator operators stats from all tasks
will be merged. It does make sense to perform
merging as bulk operation.

On top of #16668

@sopel39 sopel39 requested review from raunaqmorarka and Dith3r March 22, 2023 10:39
@cla-bot cla-bot bot added the cla-signed label Mar 22, 2023
@sopel39 sopel39 force-pushed the ks/merge_agg branch 2 times, most recently from e2cc254 to ddc11d6 Compare March 22, 2023 10:40
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be any additional testing in TestMetrics ?

On coordinator operators stats from all tasks
will be merged. It does make sense to perform
merging as bulk operation.
@sopel39 sopel39 merged commit 3ba53d2 into trinodb:master Mar 22, 2023
@sopel39 sopel39 deleted the ks/merge_agg branch March 22, 2023 13:46
@sopel39 sopel39 mentioned this pull request Mar 22, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants