Remove Iceberg, Delta $data system table #16650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail, instead of returning, on an impossible case that was supposed to be handled earlier in a method.
Leverage information already had within the method.
findepi
requested review from
electrum,
losipiuk,
ebyhr,
alexjo2144 and
findinpath
github-actions
bot
added
delta-lake
findepi
force-pushed
the
findepi/remove-iceberg-delta-data-system-table-98c84d
branch
from
f733378 to
2b1f5e4
Compare
findepi
commented
Mar 22, 2023
| @Override | ||
| public void testNoDataSystemTable() | ||
| { | ||
| // TODO (https://github.com/trinodb/trino/issues/6515): Big Query throws an error when trying to read "some_table$data". |
It has been documented in Iceberg connector since version 370 (#10514). I don't disagree with this change, but some users may use it. Could you update both |
findepi
force-pushed
the
findepi/remove-iceberg-delta-data-system-table-98c84d
branch
from
2b1f5e4 to
3d984d8
Compare
|
Thanks @ebyhr . Update the docs (https://github.com/trinodb/trino/compare/2b1f5e4de7ca71071aa2daa9f937706e798c7497..3d984d84c57d5105fa96c3f18c27f1b4f2fd66e2) & squashed. |
It was not intentional to expose a table's data as `a_table$data` "system" table. This commit removes support for these tables.
Encapsulate constructors of IcebergTableName and DeltaLakeTableName. The classes are used primarily as utility classes. Constructor encapsulation is preparation to convert them into proper utility classes.
After recent changes it became used only in tests. This also converts the IcebergTableName, DeltaLakeTableName into utility classes.
findepi
force-pushed
the
findepi/remove-iceberg-delta-data-system-table-98c84d
branch
from
3d984d8 to
3f9806d
Compare
ebyhr
approved these changes
Mar 23, 2023
|
CI #15429 cc @elonazoulay |
findepi
deleted the
findepi/remove-iceberg-delta-data-system-table-98c84d
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not intentional to expose a table's data as
a_table$data"system" table. This commit removes support for these tables.