Add link to duration prop type in JDBC config fragment #16638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
reviewed
Mar 20, 2023
| @@ -15,7 +15,7 @@ connector: | |||
| - Support case insensitive schema and table names. | |||
| - ``false`` | |||
| * - ``case-insensitive-name-matching.cache-ttl`` | |||
| - | |||
| - This value should be a :ref:`prop-type-duration`. | |||
There was a problem hiding this comment.
How about "Value must use duration formatting" ?
ebyhr
reviewed
Mar 20, 2023
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
colebow
force-pushed
the
colebow/improve-metadata-config-docs
branch
from
fbdfd0e to
165c334
Compare
ebyhr
reviewed
Mar 20, 2023
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
colebow
force-pushed
the
colebow/improve-metadata-config-docs
branch
from
165c334 to
ba08576
Compare
ebyhr
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had a Slack question about the unclear way to configure one of the properties in this fragment. I've linked to the docs on what a duration is to make things more clear.
Release notes
(x) This is not user-visible or docs only and no release notes are required.