Add generated expression to extra info in Delta Lake #16631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
commented
Mar 20, 2023
| { | ||
| return ColumnMetadata.builder() | ||
| .setName(column.getName()) | ||
| .setType(column.getType()) | ||
| .setHidden(column.getColumnType() == SYNTHESIZED) | ||
| .setComment(Optional.ofNullable(comment)) | ||
| .setNullable(nullability) | ||
| .setExtraInfo(generation == null ? Optional.empty() : Optional.of("generated: " + generation)) |
There was a problem hiding this comment.
The expression may contain :. Do we want to just put generated without expression or quote the expression?
findepi
approved these changes
Mar 20, 2023
| { | ||
| return ColumnMetadata.builder() | ||
| .setName(column.getName()) | ||
| .setType(column.getType()) | ||
| .setHidden(column.getColumnType() == SYNTHESIZED) | ||
| .setComment(Optional.ofNullable(comment)) | ||
| .setNullable(nullability) | ||
| .setExtraInfo(generation == null ? Optional.empty() : Optional.of("generated: " + generation)) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add generated expression to extra info in Delta Lake
Release notes
(x) Release notes are required, with the following suggested text: