Improve LongSumAggregation and DoubleSumAggregation serde #16624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Mar 19, 2023
Previously row(bigint, boolean, bigint, boolean)] was used for long sum serde (and similar for doubles). Now it's row(bigint, bigint) The extra bigint (row count) is still only required for WINDOW function but this PR slighly improves serde. We can remove extra booleans because Long and Decimal aggregations use row count to determine if null should be outputted.
sopel39
force-pushed
the
ks/improve_serde
branch
from
640741a to
97a6db3
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously row(bigint, boolean, bigint, boolean)] was used for long sum serde (and similar for doubles).
Now it's row(bigint, bigint)
The extra bigint (row count) is still only required for WINDOW function but this PR slighly improves serde.
We can remove extra booleans because Long and Decimal aggregations use row count to determine if null should be outputted.
RN
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: