Introduce new methods projected & exceptColumns take string varargs in QueryAssertions #16609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Mar 17, 2023
findepi
reviewed
Mar 17, 2023
plugin/trino-redshift/src/test/java/io/trino/plugin/redshift/TestRedshiftConnectorTest.java
Show resolved
Hide resolved
plugin/trino-redshift/src/test/java/io/trino/plugin/redshift/TestRedshiftConnectorTest.java
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
Outdated
Show resolved
Hide resolved
findepi
added
test
no-release-notes
krvikash
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
cd8fb28 to
caeaae4
Compare
krvikash
commented
Mar 21, 2023
testing/trino-tests/src/test/java/io/trino/tests/BaseQueryAssertionsTest.java
Show resolved
Hide resolved
krvikash
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
caeaae4 to
16ae772
Compare
krvikash
changed the title
krvikash
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
16ae772 to
6a8b280
Compare
|
CI is failing with #16315 |
krvikash
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
6a8b280 to
d74a86a
Compare
|
Rebased with master. |
findepi
reviewed
Mar 22, 2023
| @@ -892,6 +893,9 @@ private MaterializedResultWithPlan executeInternal(Session session, @Language("S | |||
| } | |||
|
|
|||
| verify(builder.get() != null, "Output operator was not created"); | |||
| if (plan.getRoot() instanceof OutputNode outputNode) { | |||
There was a problem hiding this comment.
All test cases are passing, So I assume check is not required.
core/trino-main/src/main/java/io/trino/testing/MaterializedResult.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/testing/MaterializedResult.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/testing/MaterializedResult.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
d74a86a to
0a341fb
Compare
krvikash
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
0a341fb to
d30528d
Compare
findepi
approved these changes
Mar 23, 2023
core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/BaseQueryAssertionsTest.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/BaseQueryAssertionsTest.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/BaseQueryAssertionsTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcTableStatisticsTest.java
Show resolved
Hide resolved
krvikash
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
d30528d to
306b2c4
Compare
For better readability, replace projected(int... columns) with projected(String... columnNamesToInclude) and introduce exceptColumns(String... columnNamesToExclude) leveraging MaterializedResult.getColumnNames
findepi
force-pushed
the
remove-use-of-deprecated-projected-method
branch
from
306b2c4 to
3d41fff
Compare
|
Fixed unnecessary use of a linkedhashset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For better readability, replace
projected(int... columns)withprojected(String... columnNamesToInclude)and introduceexceptColumns(String... columnNamesToExclude)leveragingMaterializedResult.getColumnNames