Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Hive from returning table handles for Hudi tables #16605

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Prevent Hive from returning table handles for Hudi tables #16605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,9 @@ public HiveTableHandle getTableHandle(ConnectorSession session, SchemaTableName
if (isIcebergTable(table)) {
throw new TrinoException(UNSUPPORTED_TABLE_TYPE, format("Cannot query Iceberg table '%s'", tableName));
}
if (isHudiTable(table)) {
throw new TrinoException(UNSUPPORTED_TABLE_TYPE, format("Cannot query Hudi table '%s'", tableName));
}

// we must not allow system tables due to how permissions are checked in SystemTableAwareAccessControl
if (getSourceTableNameFromSystemTable(systemTableProviders, tableName).isPresent()) {
Expand Down
3 changes: 2 additions & 1 deletion plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,8 @@ public static boolean isIcebergTable(Map<String, String> tableParameters)
public static boolean isHudiTable(Table table)
{
requireNonNull(table, "table is null");
String inputFormat = table.getStorage().getStorageFormat().getInputFormat();
@Nullable
String inputFormat = table.getStorage().getStorageFormat().getInputFormatNullable();

return HUDI_PARQUET_INPUT_FORMAT.equals(inputFormat) ||
HUDI_PARQUET_REALTIME_INPUT_FORMAT.equals(inputFormat) ||
Expand Down