Fix hashing in BlackHoleNodePartitioningProvider #16599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It ignored `position` and didn't check for null, so could fail. Even if this doesn't matter for blackhole connector, the code could be used as inspiration for other bucketing function implementations.
raunaqmorarka
approved these changes
Mar 17, 2023
| @@ -392,7 +392,6 @@ private IntArrayList[] partitionNotNullPositions(Page page, int startingPosition | |||
| partitionPositions[partitionPerPosition[position]].add(position); | |||
| } | |||
|
|
|||
findepi
force-pushed
the
findepi/fix-hashing-in-blackholenodepartitioningprovider-26403b
branch
from
bb34e1f to
50744b6
Compare
findepi
deleted the
findepi/fix-hashing-in-blackholenodepartitioningprovider-26403b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It ignored
positionand didn't check for null, so could fail.Even if this doesn't matter for blackhole connector, the code could be used as inspiration for other bucketing function implementations.