Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsonwebtoken to 0.11.5 #16548

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

aislinnjeske
Copy link
Contributor

@aislinnjeske aislinnjeske commented Mar 14, 2023

Description

Upgrading dep.jsonwebtoken.version to 0.11.5 in the parent pom.xml file. Resolves issue number #16474

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. (`#16474`)

@cla-bot cla-bot bot added the cla-signed label Mar 14, 2023
@electrum
Copy link
Member

Thanks for the PR. Can you explain the reasoning for the upgrade? Are there specific bugs or features that would affect Trino users?

@electrum
Copy link
Member

I see from the JJWT CHANGELOG that this versions adds a workaround for a security bug in the JDK, so we should upgrade. While it's generally good to be on the latest versions of libraries, we like to understand why we are upgrading, what the implications are, etc.

@electrum electrum merged commit 40cff41 into trinodb:master Mar 15, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants