Simplify column adaptations for parquet in iceberg #16547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
hive
raunaqmorarka
force-pushed
the
simplify-pagesource
branch
4 times, most recently
from
f79c230 to
7905854
Compare
skrzypo987
approved these changes
Mar 17, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSource.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
simplify-pagesource
branch
from
7905854 to
033694d
Compare
alexjo2144
approved these changes
Mar 17, 2023
alexjo2144
reviewed
Mar 17, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSource.java
Show resolved
Hide resolved
Avoids having two different column adaptation layers for parquet in iceberg Makes ParquetPageSource more consistent with OrcPageSource
raunaqmorarka
force-pushed
the
simplify-pagesource
branch
from
033694d to
3b07c07
Compare
sopel39
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids having two different column adaptation layers
for parquet in iceberg
Makes ParquetPageSource more consistent with OrcPageSource
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: