Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for trailing space in location in hive metadata #16544

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Add test for trailing space in location in hive metadata #16544

merged 1 commit into from
Mar 28, 2023

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented Mar 14, 2023

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Mar 14, 2023
@pajaks
Copy link
Member Author

pajaks commented Mar 14, 2023

@ebyhr @findepi Could you run with secretes?

@github-actions github-actions bot added hive Hive connector tests:hive labels Mar 14, 2023
@ebyhr
Copy link
Member

ebyhr commented Mar 14, 2023

/test-with-secrets sha=3527cc78f165fd241dedb3dc63f46dd8281d6ea6

@github-actions
Copy link

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4420947104

@pajaks pajaks self-assigned this Mar 15, 2023
@pajaks pajaks marked this pull request as ready for review March 16, 2023 08:43
@pajaks pajaks requested review from findinpath and ebyhr March 16, 2023 08:43
@pajaks
Copy link
Member Author

pajaks commented Mar 17, 2023

Rebased to include fix for skipped tests in CI

@ebyhr
Copy link
Member

ebyhr commented Mar 20, 2023

/test-with-secrets sha=2b64fc19464e0ea355d949ea3396c550aefd58b4

@ebyhr
Copy link
Member

ebyhr commented Mar 27, 2023

/test-with-secrets sha=097084e30b7de3aa5cb726b4ca5929b0b89533ec

@github-actions
Copy link

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4533544841

@ebyhr
Copy link
Member

ebyhr commented Mar 27, 2023

Could you confirm CI failure?

Error:  Tests run: 95, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 163.58 s <<< FAILURE! - in io.trino.plugin.hive.TestHive
Error:  io.trino.plugin.hive.TestHive.testTableCreationWithTrailingSpaceInLocation  Time elapsed: 0.017 s  <<< FAILURE!
java.lang.IllegalArgumentException: Wrong FS: hdfs://hadoop-master:9000/user/hive/warehouse/tmp_trino_test_test_table_creation_with_trailing_space_in_location_5w96076bmm_754e382b8d0c4e1793f934108d5871d8 , expected: file:///
	at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:737)
	at org.apache.hadoop.fs.RawLocalFileSystem.pathToFile(RawLocalFileSystem.java:87)
	at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:661)
	at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:987)
	at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:656)
	at org.apache.hadoop.fs.ChecksumFileSystem.delete(ChecksumFileSystem.java:642)
	at org.apache.hadoop.fs.FilterFileSystem.delete(FilterFileSystem.java:264)
	at io.trino.plugin.hive.AbstractTestHive.testTableCreationWithTrailingSpaceInLocation(AbstractTestHive.java:2658)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

https://github.com/trinodb/trino/actions/runs/4533544841/jobs/7986503120

@pajaks
Copy link
Member Author

pajaks commented Mar 28, 2023

Problem is caused by my changes. I am looking into it.

@pajaks
Copy link
Member Author

pajaks commented Mar 28, 2023

Test should work now. @ebyhr Can you run with secretes?

@ebyhr
Copy link
Member

ebyhr commented Mar 28, 2023

/test-with-secrets sha=657e0685270c67052aa8609b3f93405c50470daa

@github-actions
Copy link

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4541727865

@ebyhr
Copy link
Member

ebyhr commented Mar 28, 2023

The above failure is unrelated to this change.

@ebyhr ebyhr merged commit 04e6417 into trinodb:master Mar 28, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector
Development

Successfully merging this pull request may close these issues.

3 participants