-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for trailing space in location in hive metadata #16544
Conversation
/test-with-secrets sha=3527cc78f165fd241dedb3dc63f46dd8281d6ea6 |
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4420947104 |
Rebased to include fix for skipped tests in CI |
/test-with-secrets sha=2b64fc19464e0ea355d949ea3396c550aefd58b4 |
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
Outdated
Show resolved
Hide resolved
/test-with-secrets sha=097084e30b7de3aa5cb726b4ca5929b0b89533ec |
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4533544841 |
Could you confirm CI failure?
https://github.com/trinodb/trino/actions/runs/4533544841/jobs/7986503120 |
Problem is caused by my changes. I am looking into it. |
Test should work now. @ebyhr Can you run with secretes? |
/test-with-secrets sha=657e0685270c67052aa8609b3f93405c50470daa |
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4541727865 |
The above failure is unrelated to this change. |
Release notes
(x) This is not user-visible or docs only and no release notes are required.