Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inline non-deterministic expressions as projection #16518

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

kasiafi
Copy link
Member

@kasiafi kasiafi commented Mar 13, 2023

Description

fixes #16512

The incorrect result was caused by the Optimizer rule ReplaceJoinOverConstantWithProject, which inlined a non-deterministic expression (in this case, uuid()), causing it to be evaluated separately for every row.

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text:

# General
* Fix potential incorrect result in queries involving join and a non-deterministic value. ({issue}`16512`)

@kasiafi kasiafi merged commit 9be8719 into trinodb:master Mar 15, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

trying to add same ranom uuid to every row
2 participants