Expose JMX RMI in product tests #16517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Mar 13, 2023
...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Standard.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/jmx-rmi-pt
branch
from
6a1fbaf to
7e1da28
Compare
wendigo
force-pushed
the
serafin/jmx-rmi-pt
branch
from
7e1da28 to
0dc27b7
Compare
kokosing
reviewed
Mar 13, 2023
...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Standard.java
Show resolved
Hide resolved
|
I like it! |
kokosing
approved these changes
Mar 13, 2023
findepi
reviewed
Mar 13, 2023
Comment on lines
+194
to
+227
| jmxPort = 6005; | ||
| } | ||
| else if (logicalName.equals(WORKER)) { | ||
| jmxPort = 6009; | ||
| } | ||
| else if (logicalName.startsWith(WORKER_NTH)) { | ||
| int workerNumber = parseInt(logicalName.substring(WORKER_NTH.length())); | ||
| jmxPort = 6008 + workerNumber; |
There was a problem hiding this comment.
Good question. I've used the same base as in the exposing debugger part, shifted by 1000
...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Standard.java
Outdated
Show resolved
Hide resolved
...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Standard.java
Show resolved
Hide resolved
...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Standard.java
Outdated
Show resolved
Hide resolved
This allows to connect to the running Trino instance using JDK Mission Control and capture Java Flight Recorder recordings.
wendigo
force-pushed
the
serafin/jmx-rmi-pt
branch
from
0dc27b7 to
fac6b9b
Compare
|
CI hit: #14637 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to connect to the running Trino instance using JDK Mission Control and capture Java Flight Recorder recordings.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: