Fix BaseFailureRecoveryTest temp table checking flakiness #16277 #16499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwd410
force-pushed
the
mdeady-fix-fte-temp-tables-16277
branch
from
d48400f to
1b64fd4
Compare
hashhar
reviewed
Mar 10, 2023
testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
mwd410
force-pushed
the
mdeady-fix-fte-temp-tables-16277
branch
from
1b64fd4 to
da6c9c1
Compare
losipiuk
approved these changes
Mar 10, 2023
| @@ -13,6 +13,7 @@ | |||
| */ | |||
| package io.trino.testing; | |||
|
|
|||
| import com.google.common.base.Joiner; | |||
There was a problem hiding this comment.
please drop issue from commit message
mwd410
commented
Mar 10, 2023
| temporaryTableNamePrefix(entry.getKey()), | ||
| Joiner.on(",").join(entry.getValue()), | ||
| Joiner.on("],\n[").join(assertionErrorMessages.get(entry.getKey())).replace("\n", "\n\t\t\t"))) | ||
| .collect(joining("\n"))) |
There was a problem hiding this comment.
An example message from this:
There should be no remaining tmp_trino tables that are queryable. They are:
For queryId [20230310_183735_00015_ii5en] (prefix [tmp_trino_31f5781f_]) remaining tables: [tmp_trino_31f5781f_14b3eb70]
With errors: [
Expecting code to raise a throwable.]
For queryId [20230310_183738_00020_ii5en] (prefix [tmp_trino_5ce0903c_]) remaining tables: [tmp_trino_5ce0903c_2f4304bc]
With errors: [
Expecting code to raise a throwable.]
da6c9c1 to
58b1208
Compare
hashhar
approved these changes
Mar 10, 2023
mwd410
force-pushed
the
mdeady-fix-fte-temp-tables-16277
branch
from
58b1208 to
e1c915a
Compare
|
@hashhar - just pushed the additional mysql only testing 30x CTAS. |
|
Nice, looks good to go. Please don't forget to revert the MySQL changes (I just wanted them to make sure the change is effective before merging). |
mwd410
force-pushed
the
mdeady-fix-fte-temp-tables-16277
branch
from
e1c915a to
88c2901
Compare
|
@hashhar done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue described in #16277
Because
information_schemais not strictly consistent with recently dropped tables among all connectors, but querying recently dropped tables is consistent, this no longer relies onSHOW TABLES LIKEreturning no results, but instead, actually attempts to query the recently dropped temporary table, and expects there to be a "does not exist" exception.Additional context and related issues
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: